Skip to content

Commit

Permalink
Remove issue PyO3#844 mention from the guide
Browse files Browse the repository at this point in the history
Supposedly resolved by PyO3#1107

Fix a typo in the subsection header.
  • Loading branch information
ravenexp committed Apr 5, 2021
1 parent 7eb3aa3 commit 0c02146
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions guide/src/class/protocols.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Each method corresponds to Python's `self.attr`, `self.attr = value` and `del se

### Emulating numeric types

The [`PyNumberProtocol`] trait allows [emulate numeric types](https://docs.python.org/3/reference/datamodel.html#emulating-numeric-types).
The [`PyNumberProtocol`] trait allows to emulate [numeric types](https://docs.python.org/3/reference/datamodel.html#emulating-numeric-types).

* `fn __add__(lhs: impl FromPyObject, rhs: impl FromPyObject) -> PyResult<impl ToPyObject>`
* `fn __sub__(lhs: impl FromPyObject, rhs: impl FromPyObject) -> PyResult<impl ToPyObject>`
Expand Down Expand Up @@ -106,12 +106,6 @@ The reflected operations are also available:
The code generated for these methods expect that all arguments match the
signature, or raise a TypeError.

*Note*: Currently implementing the method for a binary arithmetic operations
(e.g, `__add__`) shadows the reflected operation (e.g, `__radd__`). This is
being addressed in [#844](https://github.com/PyO3/pyo3/issues/844). to make
these methods


This trait also has support the augmented arithmetic assignments (`+=`, `-=`,
`*=`, `@=`, `/=`, `//=`, `%=`, `**=`, `<<=`, `>>=`, `&=`, `^=`, `|=`):

Expand Down

0 comments on commit 0c02146

Please sign in to comment.