RDBC-698 Python client - timeseries round 2 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py from warnings
…xistingRangeInCache_Typed
…UpdateExistingRangeInCache_Typed
poissoncorp
force-pushed
the
RDBC-698
branch
from
ab30629 to
1c2b27f
Compare
…WithExistingRangesInCache_Typed
poissoncorp
force-pushed
the
RDBC-698
branch
from
1c2b27f to
ecb5809
Compare
…esIncludesTest::includeTimeSeriesAndMergeWithExistingRangesInCache
…oadAsyncWithInclude_AllTimeSeries_LastRange_ByTime, canLoadAsyncWithInclude_AllTimeSeries_LastRange_ByCount
ml054
reviewed
Dec 4, 2023
| @classmethod | ||
| def from_json(cls, json_dict: Dict[str, Any]) -> TimeSeriesPolicy: | ||
| return cls( | ||
| json_dict["Name"], | ||
| json_dict["Name"], # todo: Invalid deserialization |
There was a problem hiding this comment.
fixed in the upcoming commits in this pr https://issues.hibernatingrhinos.com/issue/RDBC-766/Python-client-time-series-3
ml054
reviewed
Dec 4, 2023
| @@ -55,7 +56,7 @@ def get_time_series_name(self, raw_name: str) -> str: | |||
|
|
|||
| def to_json(self) -> Dict[str, Any]: | |||
| return { | |||
| "Name": self.name, | |||
| "Name": self.name, # todo: Invalid serialization | |||
There was a problem hiding this comment.
fixed in the upcoming commits in this pr https://issues.hibernatingrhinos.com/issue/RDBC-766/Python-client-time-series-3
ml054
reviewed
Dec 4, 2023
| @@ -168,7 +171,7 @@ def execute_all_pending_lazy_operations(self) -> ResponseTimeInformation: | |||
| requests = [] | |||
| for i in range(len(self._pending_lazy_operations)): | |||
| # todo: pending lazy operation create request - WIP | |||
| req = self._pending_lazy_operations[i].create_request() | |||
| req = self._pending_lazy_operations[i].create_arequest() | |||
There was a problem hiding this comment.
typo, fixed in the upcoming commits in this pr https://issues.hibernatingrhinos.com/issue/RDBC-766/Python-client-time-series-3
ml054
reviewed
Dec 4, 2023
| # return a dictionary {index of time series value - (name of 'float' field, label)} | ||
| # e.g. return {0 : ('heart', 'Heartrate'), 1: ('bp', 'Blood Pressure')} | ||
| # for some class that has 'heart' and 'bp' float fields | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
ml054
reviewed
Dec 4, 2023
| self.assertIsNone(session.time_series_for(document_id, "HeartRate").get()) | ||
|
|
||
| def test_get_on_empty_range_should_return_empty_array(self): | ||
| document_id = "users/gracjan" |
There was a problem hiding this comment.
it was "users/ayende" in original source code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.hibernatingrhinos.com/issue/RDBC-698/Python-client-timeseries-round-2