Use a union to avoid UB with uninitialized &mut T #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soundness rules of
unsafe
code are not completely settled in the language, but in some proposals creating&mut T
with an uninitializedT
value is Undefined Behavior even if nothing reads from that reference.In a union with a zero-size variant however, being uninitialized is a valid state since the storage for that variant is entirely padding.
Bumping the version number because of the new
T: Copy
bound onUninitialized
, which is require because unions with non-Copy fields rust-lang/rust#32836 (or theMaybeUninit
union itself rust-lang/rust#53491) are not stable in the language yet.