refactor(home): modals #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapedcat
force-pushed
the
refactor/home-modals
branch
3 times, most recently
from
a392f09 to
65de1a6
Compare
functionality is covered by next-ui modal
escapedcat
force-pushed
the
refactor/home-modals
branch
from
de63a68 to
392ad3d
Compare
|
Will merge this after 1.11.3 Too big to check this before Release, sorry :( |
|
No worries, understandable |
cstenglein
requested changes
Oct 5, 2024
There was a problem hiding this comment.
Wow, really awesome 🚀
Must have been tons of work, thank you 👍
There is only one thing which would be cool:
in mobile, the receive and send tabs should be vertical, so they can be read:
https://nextui.org/docs/components/tabs#vertical
cstenglein
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got rather big. Should have done one modal at a time.
Before merging this please check it out and test it.
Let me know if this is too much. I can split this up into multiple PRs.
Unlock
Send
Receive
Chanel list
Open channel