Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add caps-lock hook and warning #693

Merged

Conversation

jpyepez
Copy link
Contributor

@jpyepez jpyepez commented Mar 13, 2024

Description

This PR addresses #466

  • Add caps lock detection via useCapsLock hook
  • Add CapsLockWarning component for user feedback
  • Integrate with password A, password C, and change password inputs. Important to note, hooked up both inputs in the change password modal to the same warning to avoid having to handle caps lock detection independently, and to avoid weird duplicate or out-of-sync warnings.
  • Add translations

Screen Recordings

Password A
2024-03-13_14-46-03 (1)

Password C
2024-03-13_14-47-53 (1)

Change Password A (Settings)
2024-03-13_14-50-59 (1)

@cstenglein
Copy link
Collaborator

Awesome stuff, thank you very much!

Copy link
Collaborator

@cstenglein cstenglein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for you to add the translations yourself, translations come in naturally from the community :)
PR looking good, thank you! :)

@cstenglein cstenglein merged commit 65d23e9 into raspiblitz:master Mar 19, 2024
2 checks passed
@cstenglein cstenglein linked an issue Mar 19, 2024 that may be closed by this pull request
@cstenglein cstenglein added this to the 1.3.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect if Caps Lock is on in login screen & password change
2 participants