-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepting pull requests? #17
Conversation
thanks for your contribution! Really appreciate it if someone else gives me feedback - or like you - contributes, so yes, PRs are appreciated! :) I've got one suggestion and one thing to thing we should think about how to make it nicer (the pb-10 in the dialog) Otherwise it really looks good, thank you! 👍 |
Co-authored-by: Christoph Stenglein <9399034+cstenglein@users.noreply.github.com>
… used in modal with bottom padding
I've updated pull request. The bottom margin of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes!
Still not happy about the pb-10
though 😅
Hope we can find a good solution for that.
Other than that, great work! :)
src/components/SettingsComponents/ChangePwModal/ChangePwModal.tsx
Outdated
Show resolved
Hide resolved
There were some merge conflicts so I resolved them by hand. So it could be that some changes were lost due to that but I think most made it through :) Thank you very much and sorry that it took so long! |
Hi Christoph,
This looks like a really nice project you're working on at the moment. Are you accepting pull requests? I've made a few minor changes to the UI to improve the layout slightly here and there. You've done a huge amount of work on this so far but if you're accepting small changes like this I'm happy to help.
I'm on Twitter - @blackcoffeebtc
My email is randommw@protonmail.com