Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting pull requests? #17

Merged
merged 12 commits into from
Sep 8, 2021
Merged

Conversation

blackcoffeexbt
Copy link
Contributor

Hi Christoph,

This looks like a really nice project you're working on at the moment. Are you accepting pull requests? I've made a few minor changes to the UI to improve the layout slightly here and there. You've done a huge amount of work on this so far but if you're accepting small changes like this I'm happy to help.

I'm on Twitter - @blackcoffeebtc
My email is randommw@protonmail.com

src/container/ModalDialog/ModalDialog.tsx Outdated Show resolved Hide resolved
src/container/ModalDialog/ModalDialog.tsx Outdated Show resolved Hide resolved
@cstenglein
Copy link
Collaborator

Hi @blackcoffeexbt

thanks for your contribution! Really appreciate it if someone else gives me feedback - or like you - contributes, so yes, PRs are appreciated! :)

I've got one suggestion and one thing to thing we should think about how to make it nicer (the pb-10 in the dialog)

Otherwise it really looks good, thank you! 👍

@blackcoffeexbt
Copy link
Contributor Author

I've updated pull request. The bottom margin of the ChangePwModal.tsx component has been removed to display it better within the modal with a bottom padding. The height of the AppCard.tsx component has been tweaked to h-full to display all cards with the same height.

Copy link
Collaborator

@cstenglein cstenglein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

Still not happy about the pb-10 though 😅

Hope we can find a good solution for that.

Other than that, great work! :)

src/container/ModalDialog/ModalDialog.tsx Outdated Show resolved Hide resolved
@cstenglein cstenglein merged commit b4292dc into raspiblitz:master Sep 8, 2021
@cstenglein
Copy link
Collaborator

Hi @blackcoffeexbt

There were some merge conflicts so I resolved them by hand. So it could be that some changes were lost due to that but I think most made it through :)

Thank you very much and sorry that it took so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants