Dev/tdewey/packages #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Remove rpi-otp-key, not required 2) Remove extraneous --key-file directive, harmful 3) Remove kernel module explicit loading, not required 4) Compress with zstd 5) Move binaries to /usr/bin
1) Move scripts to /usr/bin
1) Move script to /usr/bin 2) Add depends on the fastboot package
roliver-rpi
reviewed
Oct 3, 2024
| PRIVATE_KEY=$(/usr/local/bin/rpi-otp-private-key -b | base64 -w0) | ||
| printf '%s' "${PRIVATE_KEY}" > /data/fastboot.key | ||
| printf '%s' "${PRIVATE_KEY}\r\n" >> /data/private.key | ||
| /usr/bin/cryptkey-fetch | /sbin/cryptsetup luksOpen /dev/mmcblk0p2 cryptroot |
There was a problem hiding this comment.
I'm not sure cryptkey-fetch has ever been used for the LUKS passphrase (look at generate_fastboot_cfg in the fastboot package)
There was a problem hiding this comment.
Does it produce the correct output, though?
There was a problem hiding this comment.
Dug further - generate_fastboot_cfg creates, but cryptkey-fetch only reads.
| - src: vcgencmd | ||
| dst: /bin/vcgencmd | ||
| dst: /usr/bin/vcgencmd |
There was a problem hiding this comment.
vcgencmd/vcmailbox can go if you list 'raspi-utils-core' under 'depends' (it's now available on the publicly).
There was a problem hiding this comment.
Not interested in another dependency at this time - neither of these tools changes frequently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and update the packages