overlays: add wm8960-soundcard overlay #4039
Conversation
|
FYI - in the readme I left the description for the Additionally, this overlay will also bring support for (they are all clones): |
There was a problem hiding this comment.
You need to understand and explain what the "master" parameter is doing - it looks wrong to me because if set to "on" it enables fragment 2 and disables fragment 3, and if "off" it disables fragment 2 and enables fragment 3, and yet both fragments are enabled by default.
add overlay for waveshare wm8960 simple-audio-card Change-type: patch Signed-off-by: Aaron Shaw <shawaj@gmail.com>
|
@pelwell have updated the PR. As far as I can tell - the master override is not needed. I can't find anything in the docs for the board about using it or anything like that so I also agree that it is wrong, certainly for this board. Perhaps it is used for some other hardware that I am not aware of, but I can't see any function for it either. |
|
You can always add it later if a use becomes apparent. |
|
agreed, thanks @pelwell |
add overlay for waveshare wm8960 simple-audio-card
Change-type: patch
Signed-off-by: Aaron Shaw shawaj@gmail.com