Performance enhancements #81
Conversation
| @@ -158,6 +160,7 @@ public LinkType Type | |||
| } | |||
| } | |||
|
|
|||
| private UmbracoHelper Umbraco => _umbracoHelper ?? (_umbracoHelper = new UmbracoHelper(UmbracoContext.Current)); | |||
There was a problem hiding this comment.
If the UmbracoHelper was not provided in the constructor, create one here and store it in the field.
| @@ -170,9 +173,22 @@ private void InitPublishedContent() | |||
| return; | |||
| } | |||
|
|
|||
| if (Udi.TryParse(_linkItem.Value<string>("udi"), out _udi)) | |||
| if (Udi.TryParse(_linkItem.Value<string>("udi"), out _udi) && _udi is GuidUdi guidUdi) | |||
There was a problem hiding this comment.
Most of this code is copied from the ToPublishedContent() method, but now uses the same UmbracoHelper.
| if (!newLink.Deleted) | ||
| { | ||
| _multiUrls.Add(new Link(item)); | ||
| _multiUrls.Add(newLink); |
There was a problem hiding this comment.
Just add the link, no need to create a yet another one 😄
| @@ -37,22 +37,24 @@ public override bool IsConverter(PublishedPropertyType propertyType) | |||
|
|
|||
| public override object ConvertDataToSource(PublishedPropertyType propertyType, object source, bool preview) | |||
| { | |||
| if (string.IsNullOrWhiteSpace(source?.ToString())) | |||
| var sourceString = source?.ToString(); | |||
There was a problem hiding this comment.
Convert the source to a string once and then use it everywhere, no need to do the same over and over again 😀
| @@ -39,12 +40,15 @@ public MultiUrls(string propertyData) | |||
|
|
|||
| private void Initialize(JArray data) | |||
| { | |||
| // Create UmbracoHelper here, because we (probably) need it more than once | |||
| var umbracoHelper = data.Count > 1 ? new UmbracoHelper(UmbracoContext.Current) : null; | |||
There was a problem hiding this comment.
Since we only need the UmbracoHelper if the link uses content or media, creating it here and not using it could actually decrease performance. We take that chance if we have more than 1 link...
| @@ -39,12 +40,14 @@ public MultiUrls(string propertyData) | |||
|
|
|||
| private void Initialize(JArray data) | |||
| { | |||
| var umbracoHelper = new Lazy<UmbracoHelper>(() => new UmbracoHelper(UmbracoContext.Current)); | |||
There was a problem hiding this comment.
By using Lazy<UmbracoHelper> and passing the same instance, it is only created when actually needed and only once (if multiple links are added).
I've spotted some other (major) performance enhancements with initializations, see commit comments.