Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add slot mappings validator #7122

Closed
Ghostvv opened this issue Oct 28, 2020 · 0 comments · Fixed by #7210
Closed

add slot mappings validator #7122

Ghostvv opened this issue Oct 28, 2020 · 0 comments · Fixed by #7210
Assignees
@wochinge
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Milestone
2.1 Rasa Open Source

Comments

@Ghostvv
Copy link
Contributor

Ghostvv commented Oct 28, 2020

some slot mappings require certain info to be set, like from_entity requires entity. We need to add validation of the slot mappings that users create in domain, to prevent hidden errors like: https://forum.rasa.com/t/got-mapping-but-faild-to-extract-slot-name-in-rasa-formaction-anyone-please-help/36310
@Ghostvv Ghostvv added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Oct 28, 2020
@Ghostvv Ghostvv added this to the 2.1 Rasa Open Source milestone Oct 28, 2020
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. priority:high and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Oct 28, 2020
@wochinge wochinge mentioned this issue Nov 9, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wochinge wochinge

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
2.1 Rasa Open Source
Development

Successfully merging a pull request may close this issue.

add validation for slot mappings RasaHQ/rasa
2 participants
@Ghostvv @wochinge