add validation for slot mappings #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
commented
Nov 11, 2020
wochinge
force-pushed
the
slot_mapping_validation
branch
from
46b6abf to
8e97478
Compare
joejuzl
suggested changes
Nov 11, 2020
Co-authored-by: Joe Juzl <joejuzl@gmail.com>
wochinge
force-pushed
the
slot_mapping_validation
branch
from
41a084a to
b9e39f0
Compare
joejuzl
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
SlotMappingtoDomainas we require it in therasa.sharedpackagepykwalifyformscan be alistordict) (see Implement any.of Grokzen/pykwalify#112)typefield of the slot mappingStatus (please check what you already did):
black(please check Readme for instructions)