This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Some small optimizations #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since only the empty string returns false, the test for nonzero length can be expressed as a direct boolean check. Also replaced 'each' call with 'map', which removes an unused variable in the processing function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes two small adjustments:
The check for the length of the query string is performed without explicitly checking the length. Since any string of non-zero length is boolean true, there's no need for the length check.
Secondly, the
$.eachcall has been replaced with a similar$.mapcall. Using$.map, the actual value operated on is passed first, removing the need to catch an unusediparameter.