Enhancement build, structure and fix jest tests #1221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a fix, enhancement or language pack?
This is both, fix and enhancement.
On this pull request I've made the following changes:
Changed
_custom.scss
for_variables.scss
, how Laravel usesAdded Fontawesome web on scss to remove Fontawesome SVG used on JS, because it doesn't work on old browsers since Mix isn't processing
node_modules
dependencies. (Plus: build size gets lighter)Simplified .babelrc putting browserlist configuration on
package.json
. In addition to that, I've fixed deprecation warning because of use ofuglify
option who have changed toforceAllTransforms
.Enforced Unix newlines for some files, like bootstrap does
Fixed Jest tests.
Added Jest dependencie who was missing.
Changed deprecated
shallow
toshallowMount
Made scripts on package.json work with Yarn and NPM, using
$npm_execpath
how as suggested on 5.8 Suggestion : improve package.json compatibility with yarn #1216.The problem is a Yarn warning which says basicaly that it won't work in the future:
Removed unnecessary
node_modules/.bin/whatever
path from scripts onpackage.json
. See npm-run-scripts