Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RNG (random number generator) provided by RAFT #79

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Use RNG (random number generator) provided by RAFT #79

merged 6 commits into from
Nov 21, 2023

Conversation

linhu-nv
Copy link
Contributor

@linhu-nv linhu-nv commented Oct 9, 2023

Replace the random number generator (RNG) implemented by wholegraph with RNG provided by RAFT.
It is put forward by issue #7 and issue #23.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 9, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dongxuy04 dongxuy04 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 9, 2023
chuangz0
chuangz0 reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@chuangz0 chuangz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

dongxuy04
dongxuy04 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@dongxuy04 dongxuy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BradReesWork BradReesWork added this to the 23.12 milestone Nov 17, 2023
@BradReesWork
Copy link
Member

/ok to test

@BradReesWork
Copy link
Member

/ok to test

@BradReesWork
Copy link
Member

/rerun tests

@BradReesWork
Copy link
Member

/ok to test

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9dc74b7 into rapidsai:branch-23.12 Nov 21, 2023
43 checks passed
@BradReesWork BradReesWork mentioned this pull request Nov 29, 2023
Closed
@linhu-nv linhu-nv deleted the raft-rng branch April 11, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongxuy04 dongxuy04 dongxuy04 approved these changes

@chuangz0 chuangz0 chuangz0 approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
23.12
Development

Successfully merging this pull request may close these issues.
4 participants
@linhu-nv @BradReesWork @dongxuy04 @chuangz0