PR: Use top-k from RAFT #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests from external contributors require approval from a |
|
request write permission |
BradReesWork
added
improvement
|
/okay to test |
chuangz0
force-pushed
the
embeding_cache_remove_radix_topk_register
branch
from
b67113c
to
0955809
Compare
|
/okay to test |
|
/merge |
BradReesWork
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
cpp/tests/wholegraph_ops/wholegraph_csr_weighted_sample_without_replacement_tests.cuandcpp/tests/graph_ops/csr_add_self_loop_utils.curaft::warp_sort( select_k)to impl weighted_sampling_without_replacement, when sample_count>256, cub::DeviceSegmentSort is used for the implementation.block_radix_topk.cuh. replaceblock_topkin fileembedding_cache_func.cuhwithraft::warp_sort.