Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libcugraphops dependency and add CUDA 12 CI support #41

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

dongxuy04
Copy link
Contributor

@dongxuy04 dongxuy04 commented Jul 20, 2023

As libcugraphops is only needed to run GNN applications, not required by libwholgraph or pylibwholegraph, just remove it from dependency.
Updated YAML files to support CUDA 12 CI.
Fix exit code in ci/test_python.sh and also skip python test for CUDA 12 as no public stable pytorch package.

@dongxuy04 dongxuy04 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 20, 2023
@dongxuy04 dongxuy04 changed the title Remove libcugraphops dependency Remove libcugraphops dependency and add CUDA 12 CI support Jul 20, 2023
@dongxuy04 dongxuy04 marked this pull request as ready for review July 20, 2023 08:33
@dongxuy04 dongxuy04 requested a review from a team as a code owner July 20, 2023 08:33
@dongxuy04 dongxuy04 mentioned this pull request Jul 20, 2023
Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a suggestion and a question. LGTM, otherwise.

dependencies.yaml Show resolved Hide resolved
conda/recipes/libwholegraph/meta.yaml Show resolved Hide resolved
Co-authored-by: Tingyu Wang <tingyuw@nvidia.com>
@tingyu66
Copy link
Member

@BradReesWork Shall we merge this PR into refactoring?

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 3111d1f into rapidsai:refactoring Jul 25, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants