Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #36

Merged
merged 30 commits into from
Jul 12, 2023
Merged

Update docs #36

merged 30 commits into from
Jul 12, 2023

Conversation

dongxuy04
Copy link
Contributor

Updated docs

  • Added more comments in codes
  • Merged Adding Docs  #35 and enabled docs
  • Added some MarkDown docs

dongxuy04 and others added 20 commits June 25, 2023 16:35
@dongxuy04
mount /dev/shm inside container in test_cpp and enable cpp tests
303d444
@dongxuy04
Replace POSIX shm func with System V shm func to get rid of shm-size …
6ed5daa 
…need for container
@dongxuy04
added need for pytorch
5fa8ab5
@dongxuy04
fix style
a2bcbaf
@dongxuy04
use pytorch-cuda for dependency and disable append_unique for cpp test
bd78bb6
@dongxuy04
update dependency and log for aarch64
ff7e41c
@dongxuy04
update dependency
e4797ad
@dongxuy04
disable graph_csr_add_self_loop_test for cpp
885ad2a
@dongxuy04
disable wholegraph_csr_unweighted_sample_without_replacement_tests fo…
8ffecb7 
…r cpp
@dongxuy04
debug aarch64 cpp test
d02d0dd
@dongxuy04
debug aarch64 cpp test, enable all
74289e7
@dongxuy04
revert change and retest all, enable all
06c5aea
@dongxuy04
revert change and retest all, enable all
964bd6e
@hello-11
debug append unique op
4bae876
@hello-11
adjust code style
15203c8
@dongxuy04
disable python test for aarch64 for no pytorch cuda support
fc089bb
@dongxuy04
remove logs
9d72893
@dongxuy04
fix comm test
65e6f7f
@dongxuy04
Merge branch 'rapidsai:refactoring' into refactoring
0abfe54
@dongxuy04
Update docs for wholegraph
f4474ef
@dongxuy04 dongxuy04 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 9, 2023
@BradReesWork BradReesWork linked an issue Jul 10, 2023 that may be closed by this pull request
Add docs to WholeGraph build #37
Closed
@BradReesWork BradReesWork added this to the 23.08 milestone Jul 10, 2023
@dongxuy04 dongxuy04 marked this pull request as ready for review July 11, 2023 12:10
@dongxuy04 dongxuy04 requested a review from a team as a code owner July 11, 2023 12:10
BradReesWork
BradReesWork requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doxygen files cannot be found. Sphynx is looking in the docs/wholegraph/_xml founder but the files are under cpp/build/xml

acostadon
acostadon approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Noticed a bunch of rst files aren't in a toc.

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6a758cf into rapidsai:refactoring Jul 12, 2023
22 checks passed
@dongxuy04 dongxuy04 deleted the refactoring branch July 13, 2023 00:43
@BradReesWork BradReesWork mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@acostadon acostadon acostadon approved these changes

@ajschmidt8 ajschmidt8 Awaiting requested review from ajschmidt8

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
23.08
Development

Successfully merging this pull request may close these issues.

Add docs to WholeGraph build
4 participants
@dongxuy04 @BradReesWork @acostadon @hello-11