Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to fix CI: Use System V API instead of POSIX API for host shared memory #34

Merged
merged 18 commits into from
Jun 28, 2023
Merged

try to fix CI: Use System V API instead of POSIX API for host shared memory #34

merged 18 commits into from
Jun 28, 2023

Conversation

dongxuy04
Copy link
Contributor

@dongxuy04 dongxuy04 commented Jun 25, 2023 •
edited
Loading

Try to fix CI.

  • Use System V API for host shared memory, so that we don't rely on /dev/shm size. Depending on /dev/shm size need --shm-size flag at container startup, for RAPIDS CI this may need support in shared-action-workflows.
  • Enabled all cpp tests.
  • Fixed append_unique_tests and wholememory_comm_tests in cpp tests.
  • Enabled all Python tests except for aarch64. Seems there is no public pytorch package avaiable supporting CUDA for aarch64.

@dongxuy04 dongxuy04 requested a review from a team as a code owner June 25, 2023 08:39
@dongxuy04 dongxuy04 changed the title try to fix CI: mount /dev/shm inside container in test_cpp and enable cpp tests try to fix CI: Use System V API instead of POSIX API for host shared memory Jun 25, 2023
@BradReesWork BradReesWork added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 26, 2023
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 5f0924e into rapidsai:refactoring Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dongxuy04 @BradReesWork @hello-11