Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new memory type: Hierarchy #227

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Add a new memory type: Hierarchy #227

merged 6 commits into from
Oct 10, 2024

Conversation

zhuofan1123
Copy link
Contributor

This PR adds a new memory type called Hierarchy, which exploits power-law degree distribution in graph to reduce inter-node communication.

  1. Hierarchy WholeMemory has the same storage pattern as Distributed WholeMemory and only optimizes the gather function.
  2. Hierarchy WholeMemory can achieve 1.5x-2.0x speedup in multi-node gather, compared with Distributed.
  3. For intra-node host memory location, Hierarchy can still achieve 1.5x-2.0x speedup.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@BradReesWork BradReesWork added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 9, 2024
@BradReesWork
Copy link
Member

/okay to test

linhu-nv
linhu-nv approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@linhu-nv linhu-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@BradReesWork
Copy link
Member

/okay to test

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 98e6272 into rapidsai:branch-24.12 Oct 10, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@linhu-nv linhu-nv linhu-nv approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuofan1123 @BradReesWork @linhu-nv