Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

clarify which dependencies in dependencies.yaml are conda-only #195

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jameslamb
Copy link
Member

This project has some dependencies in dependencies.yaml which are part of groups that have output_types: requirements, but which use version specifiers that aren't recognized by pip.

For example, the use of a secondary build component matching a build string (a conda-specific pattern):

- pytorch=1.11.0=*cuda112*

And the use of a single = pin (not recognized by pip)

- pytorch-cuda=11.8

I believe these were intended to only affect conda outputs from rapids-dependency-file-generator. This marks them that way.

Notes for Reviewers

I discovered this while running the following cuda11.8-pip unified devcontainer from https://github.com/rapidsai/devcontainers.

rapids-make-pip-env --force

That resulted in an error like this when wholegraph was included.

ERROR: Invalid requirement: 'pytorch-cuda=11.8': Expected end or semicolon (after name and no valid version specifier)
    pytorch-cuda=11.8
                ^ (from line 75 of /tmp/rapids.requirements.txt)
Hint: = is not a valid operator. Did you mean == ?

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 22, 2024
@jameslamb jameslamb changed the title WIP: clarify which dependencies in dependencies.yaml are conda-only clarify which dependencies in dependencies.yaml are conda-only Jul 22, 2024
@jameslamb jameslamb marked this pull request as ready for review July 22, 2024 16:32
@jameslamb jameslamb requested a review from a team as a code owner July 22, 2024 16:32
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 94367fd into rapidsai:branch-24.08 Jul 22, 2024
53 checks passed
@jameslamb jameslamb deleted the deps branch July 22, 2024 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants