Add CUDA_STATIC_MATH_LIBRARIES #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the CUDA math libraries is independent of the CUDA runtime. Make their static/shared status separately controllable.
KyleFromNVIDIA
added
improvement
robertmaynard
approved these changes
Jul 8, 2024
vyasr
approved these changes
Jul 8, 2024
|
/merge |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/wholegraph
that referenced
this pull request
Jul 12, 2024
This reverts commit 0e0284c.
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
#190 was supposed to separate static CUDA math libraries from static CUDA runtime library, but accidentally pulled the runtime along with the math libraries. The way we'd normally fix this is by creating a separate variable for the runtime. However, since this project doesn't actually use any math libraries, we can just revert the whole thing. Contributes to rapidsai/build-planning#35 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the CUDA math libraries is independent of the CUDA runtime. Make their static/shared status separately controllable.
Contributes to rapidsai/build-planning#35