This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Sort indices before gathering #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhu-nv
reviewed
May 28, 2024
There was a problem hiding this comment.
maybe it's better to set raw_indices the same type as indices
linhu-nv
reviewed
May 28, 2024
There was a problem hiding this comment.
In my opinion, whether we use gather_with_sorted_ids should also be related to embedding data type, not just to embedding dim.
chuangz0
added
improvement
zhuofan1123
force-pushed
the
gather_with_sorted_indices
branch
from
36a7456 to
9105ab6
Compare
|
/okay to test |
zhuofan1123
force-pushed
the
gather_with_sorted_indices
branch
from
68bd1bd to
2a183f4
Compare
|
/okay to test |
|
/merge |
BradReesWork
approved these changes
May 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuous/chunked host mode, sorting indices before gathering can improve bandwidth by enhancing memory locality.