Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

remove an unnecessary sync in exchange_embeddings_nccl_func #143

Merged
merged 2 commits into from
Mar 12, 2024
Merged

remove an unnecessary sync in exchange_embeddings_nccl_func #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30978be
remove an unnecessary sync in exchange_embeddings_nccl_func
linhu-nv Mar 5, 2024
ad81cf5
Merge branch 'branch-24.04' into remove_unnecessary_sync
linhu-nv Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/wholememory_ops/functions/exchange_embeddings_nccl_func.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ wholememory_error_code_t exchange_embeddings_nccl_func(const void* dev_local_gat
WHOLEMEMORY_DT_INT8,
stream);
WM_CUDA_DEBUG_SYNC_STREAM(stream);
WHOLEMEMORY_EXPECTS(wm_comm->sync_stream(stream) == WHOLEMEMORY_SUCCESS,
"Embedding AllToAllV failed.");
// WHOLEMEMORY_EXPECTS(wm_comm->sync_stream(stream) == WHOLEMEMORY_SUCCESS,
// "Embedding AllToAllV failed.");
} catch (wholememory::logic_error& wle) {
WHOLEMEMORY_ERROR("exchange_embeddings_nccl_func LOGIC Error %s\n", wle.what());
return WHOLEMEMORY_LOGIC_ERROR;
Expand Down
Loading