This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
allow users to control gather/scatter sms #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuangz0
added
feature request
chuangz0
reviewed
Feb 1, 2024
cpp/src/wholememory/embedding.hpp
Outdated
| @@ -96,6 +97,7 @@ class embedding_base : public wholememory_embedding_ { | |||
| wholememory_error_code_t create_optimizer_states() noexcept; | |||
| wholememory_error_code_t destroy_optimizer_states() noexcept; | |||
|
|
|||
| int gather_sms; | |||
There was a problem hiding this comment.
change gather_sms to gather_sms_
chuangz0
reviewed
Feb 1, 2024
|
|
||
| ) | ||
| cudaStream_t stream, | ||
| int gather_sms) |
There was a problem hiding this comment.
add line (void)gather_sms; to avoid warning about unused variables.
chuangz0
reviewed
Feb 1, 2024
chuangz0
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to control the SMs number while gather/scatter from raw embeddings.