Fix setting Python futures when they have already completed #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent calling
set_result()
/set_exception()
on Python futures if they are alreadycancelled()
/done()
. Callingset_result()
/set_exception()
when the future has already completed raises an exception that may be uncatched as it may happen on a thread different from the application, which seems to have been one of the reasons whydistributed-ucxx
tests have been hanging.Although not all test failures have been resolved by this, hangs have seemingly also been less frequent in local tests.
Additionally set more sensible log levels for other errors coming from CPython implementation and remove the
PyErr_Print()
which will just print a message to stdout instead of a log message.