Test fixes and workarounds #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed previously as it's not _always_ necessary, for example InfiniBand will work correctly with or without it, but the server may close too soon when using TCP.
The tests marked may hang until they timeout under certain circumstances. See rapidsai#19 .
|
Changes here were introduced as part of #18, but since they're not part of the CI setup I cherry-picked them into this PR. To expedite review in #18 I'm merging this myself. @wence- would appreciate if you could take a look at the changes here if you have the chance some time this week, we can address anything in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test fixes, as well as workarounds for some tests that occur in CI but hard to reproduce locally.