Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove script input from publish step in build.yaml. #977

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Remove script input from publish step in build.yaml. #977

merged 1 commit into from
Jul 26, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 26, 2023

Nightly tests failed because an extra script variable was passed to the wheel publish workflow.

Failures look like:

Invalid workflow file: .github/workflows/build.yaml#L65
The workflow is not valid. .github/workflows/build.yaml (Line: 65, Col: 15): Invalid input, script is not defined in the referenced workflow.

https://github.com/rapidsai/ucx-py/actions/runs/5664871243

Follow-up to #973.

@bdice bdice requested a review from a team as a code owner July 26, 2023 05:24
pentschev
pentschev reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdice !

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 07b15e3 into rapidsai:branch-0.33 Jul 26, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev left review comments

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @pentschev @raydouglass