Add RAPIDS_DOCS_DIR to custom-job.yaml
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is necessary for rapidsai/gha-tools#56. Note: this path uses `/tmp` instead of the `${{ github.workspace }}` convention used in places like this: https://github.com/rapidsai/shared-action-workflows/blob/914f969d872d37d57f5449407635fc3ddb8d8e4b/.github/workflows/conda-cpp-tests.yaml#L103-L105. The problem with `github.workspace` is that it's the same directory that the code is checked out to. Therefore since a `docs` directory already exists in `cudf`'s root directory, this would cause problems. Assuming this `/tmp` path works as expected, I will open up a follow-up PR to update the `github.workspace` instances to follow this convention.
AyodeAwe
approved these changes
May 24, 2023
|
Reverted in #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is necessary for rapidsai/gha-tools#56.
Note: the path in this PR uses
/tmpinstead of the${{ github.workspace }}convention used in places like this: https://github.com/rapidsai/shared-action-workflows/blob/914f969d872d37d57f5449407635fc3ddb8d8e4b/.github/workflows/conda-cpp-tests.yaml#L103-L105The problem with
github.workspaceis that it's the same directory that the code is checked out to. Therefore since adocsdirectory already exists incudf's root directory, this would cause problems. Assuming this/tmppath works as expected, I will open up a follow-up PR to update thegithub.workspaceinstances to follow this convention.