-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop CentOS 7 from workflows. #192
Conversation
@jameslamb @ajschmidt8 @vyasr Feel free to weigh in on this set of matrix changes. I replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, is there a some kind of chart somewhere that we check against to know how much of an ideal spread across supported OS’s/combinations we’re getting for our tests?
@AyodeAwe Good question. We don't have a chart, but this is the process we used last time we reconfigured the CI matrix: rapidsai/build-planning#5 (comment) There is also a lot of discussion on #184. |
Sorry I wasn't able to get to this yesterday. Changes look good to me 👍🏻 |
This PR tests rapidsai/shared-workflows#192, which drops CentOS 7 support. See rapidsai/build-planning#23. This PR removes the logic needed to build and test both `manylinux_2_17` and `manylinux_2_28` wheels, as we will only be building for `manylinux_2_28`. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Vyas Ramasubramani (https://github.com/vyasr) URL: #15323
This PR drops CentOS 7. See rapidsai/build-planning#23.