Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build generate_ctest_json in try_compile() #537

Merged
merged 28 commits into from
Feb 26, 2024
Merged

Build generate_ctest_json in try_compile() #537

merged 28 commits into from
Feb 26, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner February 7, 2024 15:47
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 7, 2024
@KyleFromNVIDIA KyleFromNVIDIA changed the title Build generate_ctest_json in a try_compile() Build generate_ctest_json in execute_process() Feb 7, 2024
@KyleFromNVIDIA KyleFromNVIDIA changed the title Build generate_ctest_json in execute_process() Build generate_ctest_json in CMake execute_process() Feb 7, 2024
@KyleFromNVIDIA KyleFromNVIDIA changed the title Build generate_ctest_json in CMake execute_process() Build generate_ctest_json in try_compile() Feb 7, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 15f3588 into rapidsai:branch-24.04 Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleFromNVIDIA @robertmaynard