Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.5.1 #2378

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:28
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:28
@KyleFromNVIDIA KyleFromNVIDIA requested a review from AyodeAwe July 16, 2024 13:28
@jameslamb jameslamb requested review from jameslamb and removed request for AyodeAwe July 16, 2024 15:01
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These places are technically not "missed", they are accurate ... but I do think we should update them to CUDA 12.5, to help encourage the use of newer CUDA versions.

raft/README.md

Lines 283 to 285 in ab5e128

```bash
# for CUDA 12.0
mamba install -c rapidsai -c conda-forge -c nvidia raft-dask pylibraft cuda-version=12.0

raft/README.md

Lines 291 to 293 in ab5e128

```bash
# for CUDA 12.0
mamba install -c rapidsai -c conda-forge -c nvidia libraft libraft-headers cuda-version=12.0

@jakirkham
Copy link
Member

jakirkham commented Jul 16, 2024

Do we want to update these?

Edit: Noticed this line in rapidsai/docker. Maybe we should leave these as-is for now

@jameslamb
Copy link
Member

Edit: Noticed this line in rapidsai/docker. Maybe we should leave these as-is for now

You can safely change that. That's setting a default for a build argument that's always overridden. I'm going to propose removing that default (precisely for this reason of not confusing people) once rapidsai/docker CI is unblocked.

@jakirkham
Copy link
Member

After discussing offline, we decided to punt on RAFT ANN for now. This is in part as we understand this to benchmark related and it may involve more than updating the versions (like rerunning the benchmark and looking for changes). Have raised an issue for follow up: #2383

We can circle back once we know better how to proceed

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 1dd0642 into rapidsai:branch-24.08 Jul 17, 2024
69 checks passed
@jakirkham
Copy link
Member

Thanks Kyle and James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants