Convert CUDA version to major.minor during conda-pack #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
are these files still being used by anyone?
how are they consumed?
I ask because this PR will change the format of the uploaded file name.
and I think when I migrated this job to GHAs, I had changed the file name as well.
so if the filenames are changing and we're not announcing these changes, is anyone actually using these artifacts?
They are used infrequently by some RAPIDS team members. There's been some discussions about advertising more widely, but nothing concrete. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the build problem seen here: https://github.com/rapidsai/integration/actions/runs/5681986332/job/15399831914
Filed an issue to follow up on CI for this: #671