Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark #16

Merged
merged 8 commits into from
Nov 26, 2020
Merged

Benchmark #16

merged 8 commits into from
Nov 26, 2020

Conversation

RAMitchell
Copy link
Contributor

Adds google benchmarks

@RAMitchell RAMitchell force-pushed the benchmark branch 2 times, most recently from c57c6bf to 8f186b5 Compare October 29, 2020 01:15
Copy link
Contributor

@dillon-cullinan dillon-cullinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the benchmark running out of the GPU test. ASV and benchmarking efforts are still in a WIP state, and don't work in PRs right now.

ci/gpu/build.sh Outdated
Comment on lines 75 to 83
################################################################################
# TEST - Run Benchmarks
################################################################################
logger "Benchmark..."
cd $WORKSPACE/build
./BenchmarkGPUTreeShap --benchmark_out=gputreeshap_bench.json --benchmark_out_format=json
curl -L https://raw.githubusercontent.com/rapidsai/benchmark/main/parser/GBenchToASV.py --output GBenchToASV.py
python GBenchToASV.py -d . -t ${S3_ASV_DIR} -n gputreeshap -b $(git rev-parse --abbrev-ref HEAD)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed as per above

Copy link
Contributor

@dillon-cullinan dillon-cullinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental double post..

@RAMitchell RAMitchell merged commit d5d948c into rapidsai:main Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants