add opentelemery helper scripts #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
msarahan
force-pushed
the
add-telemetry-traceparent-scripts
branch
from
1f9c03f
to
d909d08
Compare
msarahan
force-pushed
the
add-telemetry-traceparent-scripts
branch
from
df3a2fa
to
47bbd45
Compare
msarahan
force-pushed
the
add-telemetry-traceparent-scripts
branch
from
268dedf
to
eb81f91
Compare
ajschmidt8
approved these changes
Oct 10, 2024
msarahan
added a commit
to msarahan/gha-tools
that referenced
this pull request
Oct 14, 2024
msarahan
added a commit
to msarahan/gha-tools
that referenced
this pull request
Oct 14, 2024
msarahan
added a commit
to msarahan/gha-tools
that referenced
this pull request
Oct 14, 2024
msarahan
added a commit
to msarahan/gha-tools
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These scripts are consumed primarily in https://github.com/rapidsai/shared-actions. The main purpose they serve is in reproducibly obtaining trace ids and span ids. The former is a global ID that groups many spans.
This PR does apply the new wrapper here to several scripts, such that tracing information is readily added there. The wrapper does nothing unless the
otel-clibinary is available and the TRACEPARENT environment variable is set. It should have no effect on existing infrastructure otherwise (but we should test it to make sure).