Remove cuSpatial notebooks #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
|
Notebook failures include:
Given that these are known failures, I think this PR succeeded in its goals of removing cuSpatial notebooks. |
I believe this has been moved to |
3 tasks
|
Fix for that is here: rapidsai/cugraph#4964 I added back a skip for the cuGraph notebook. I only meant to remove cuSpatial and cuSignal notebooks. |
bdice
commented
Mar 10, 2025
jameslamb
approved these changes
Mar 10, 2025
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Mar 12, 2025
We have some failing notebooks in the Docker image because `cugraph.experimental.datasets` doesn't exist. This appears to be promoted to `cugraph.datasets`, so I updated code referencing the old location. This corrects failures observed in rapidsai/docker#742. Authors: - Bradley Dice (https://github.com/bdice) - Don Acosta (https://github.com/acostadon) Approvers: - Don Acosta (https://github.com/acostadon) URL: #4964
raydouglass
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes cuSpatial notebooks from the notebook container. Most of these notebooks are unsupported for various reasons, so this ensures the notebook container ships examples that are widely supported.