Skip to content

Commit

Permalink
add CUDA 12.5 images (#689)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#73

Proposes the following:

* adding CUDA 12.5 images
* PR builds:
    * +1 test job covering `(cuda=12.5, arch=arm64)`
* branch builds:
    * +1 test job covering `(cuda=12.5, arch=x86_64)`
    * -1  test job covering `(cuda=12.2, arch=arm64)`

context: rapidsai/build-planning#73 (comment)

## Notes for Reviewers

Per offline discussion with @raydouglass , this would be accompanied by a deprecation notice in the RAPIDS 24.08 release stating that the CUDA 12.2 images will be removed in some future release (future release not yet determined).

Authors:
  - James Lamb (https://github.com/jameslamb)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - https://github.com/jakirkham

URL: #689
  • Loading branch information
jameslamb authored Jul 20, 2024
1 parent bfc1356 commit d240fc3
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
RAPIDS_VER=${{ inputs.RAPIDS_VER }}
tags: ${{ inputs.RAFT_ANN_BENCH_DATASETS_TAG }}-${{ matrix.ARCH }}
- name: Build RAFT ANN Benchmarks CPU image
if: inputs.CUDA_VER == '12.2.2' # we don't need to build CPU packages for different CUDA versions.
if: inputs.CUDA_VER == '12.5.1' # we don't need to build CPU packages for different CUDA versions.
uses: docker/build-push-action@v6
with:
context: context
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1

ARG CUDA_VER=12.0.1
ARG PYTHON_VER=3.11
ARG CUDA_VER=unset
ARG PYTHON_VER=unset
ARG LINUX_DISTRO=ubuntu
ARG LINUX_DISTRO_VER=22.04
ARG LINUX_VER=${LINUX_DISTRO}${LINUX_DISTRO_VER}
Expand Down
3 changes: 2 additions & 1 deletion matrix-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ pull-request:
- { CUDA_VER: '11.8', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'earliest' }
- { CUDA_VER: '12.0', ARCH: 'amd64', PYTHON_VER: '3.10', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '12.2', ARCH: 'arm64', PYTHON_VER: '3.11', GPU: 'a100', DRIVER: 'latest' }
- { CUDA_VER: '12.5', ARCH: 'amd64', PYTHON_VER: '3.11', GPU: 'v100', DRIVER: 'latest' }
branch:
- { CUDA_VER: '11.8', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'earliest' }
- { CUDA_VER: '11.8', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '12.0', ARCH: 'amd64', PYTHON_VER: '3.10', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '12.0', ARCH: 'arm64', PYTHON_VER: '3.10', GPU: 'a100', DRIVER: 'latest' }
- { CUDA_VER: '12.2', ARCH: 'amd64', PYTHON_VER: '3.11', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '12.2', ARCH: 'arm64', PYTHON_VER: '3.11', GPU: 'a100', DRIVER: 'latest' }
- { CUDA_VER: '12.5', ARCH: 'arm64', PYTHON_VER: '3.11', GPU: 'a100', DRIVER: 'latest' }
1 change: 1 addition & 0 deletions matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ CUDA_VER: # Should be `<major>.<minor>.<patch>` (e.g. `11.2.2`)
- "11.8.0"
- "12.0.1"
- "12.2.2"
- "12.5.1"
PYTHON_VER:
- "3.9"
- "3.10"
Expand Down

0 comments on commit d240fc3

Please sign in to comment.