Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Documentation files to S3 #168

Closed
ajschmidt8 opened this issue Feb 22, 2023 · 3 comments · Fixed by #214
Closed

Copy Documentation files to S3 #168

ajschmidt8 opened this issue Feb 22, 2023 · 3 comments · Fixed by #214
Labels
build/test Building and testing the documentation sphinx Related to the Sphinx theme powering these docs

Comments

@ajschmidt8
Copy link
Member

We are in the process of updating the documentation-building process for RAPIDS libraries so that they upload their HTML files to S3.

In the future, S3 will be used as the "source of truth" for documentation instead of the https://github.com/rapidsai/docs/ repository. That repository will then be configured to pull the HTML files from S3 during build time.

In preparation for the removal of the HTML files from the rapidsai/docs repository, it would be helpful if the HTML files from this repository were also uploaded to S3.

Here are some additional links/comments that may be helpful:

@ajschmidt8
Copy link
Member Author

A quick note about the dirhtml changes.

Switching from the html builder to the dirhtml builder on version 0.12 of the pydata-sphinx-theme will result in some unwanted styling changes for HTML tables.

This is a bug in their theme that is resolved in this PR, which should be released very soon (see 1,2).

For the other RAPIDS libs, this isn't much of an issue because the Jenkins-based doc building jobs that commit HTML files directly to the rapidsai/docs repository still use the html builder.

It's only the new GH Actions based docs build jobs that use the dirhtml builder and upload to S3.

I anticipate that by the time we're ready to use the S3 doc files, the new pydata-sphinx-theme will have been released and therefore this will not be an issue.

@jacobtomlinson jacobtomlinson added build/test Building and testing the documentation sphinx Related to the Sphinx theme powering these docs labels Feb 23, 2023
@ajschmidt8 ajschmidt8 changed the title Copy HTML files to S3 Copy Documentation files to S3 Apr 3, 2023
@ajschmidt8
Copy link
Member Author

It looks like this task may just require editing the existing GHAs workflow below to push to S3 instead of the rapidsai/docs repository.

  • # If on main in the upstream repo then push to docs repo
    - name: Pushes build files
    uses: cpina/github-action-push-to-another-repository@v1.5.1
    if: ${{ github.repository == 'rapidsai/deployment' && github.event_name == 'push' }}
    env:
    API_TOKEN_GITHUB: ${{ secrets.WORKFLOW_TOKEN }}
    with:
    source-directory: "build/html"
    target-directory: ${{ startsWith(github.event.ref, 'refs/tags/') && 'deployment/stable' || 'deployment/nightly' }}
    destination-github-username: "rapidsai"
    destination-repository-name: "docs"
    user-email: 1898282+github-actions[bot]@users.noreply.github.com
    target-branch: gh-pages

ajschmidt8 added a commit to ajschmidt8/deployment that referenced this issue Apr 13, 2023
Closes rapidsai#168.

This PR adjusts the `build-and-deploy.yml` workflow to push the documentation files to S3.

This is needed for the upcoming overhaul to the `rapidsai/docs` repository.

I will open a subsequent PR in the future to remove the step from this workflow that commits files directly to that repository.
@ajschmidt8
Copy link
Member Author

PR: #214

jacobtomlinson pushed a commit that referenced this issue Apr 14, 2023
Closes #168.

This PR adjusts the `build-and-deploy.yml` workflow to push the documentation files to S3.

This is needed for the upcoming overhaul to the `rapidsai/docs` repository.

I will open a subsequent PR in the future to remove the step from this workflow that commits files directly to that repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/test Building and testing the documentation sphinx Related to the Sphinx theme powering these docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants