-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ProxifyHostFile.evict() #862
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #862 +/- ##
================================================
- Coverage 64.47% 64.42% -0.06%
================================================
Files 22 22
Lines 3099 3103 +4
================================================
+ Hits 1998 1999 +1
- Misses 1101 1104 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor typo fixes and question not related to this PR itself, but otherwise LGTM. Thanks @madsbk ! 😄
@@ -583,25 +583,44 @@ def oom(nbytes: int) -> bool: | |||
mr = rmm.mr.FailureCallbackResourceAdaptor(current_mr, oom) | |||
rmm.mr.set_current_device_resource(mr) | |||
|
|||
def evict(self) -> int: | |||
"""Manually evict 1% of host limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this was already like this before and not quite sure how useful that would be, but should the 1% value be configurable somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is necessary. Hopefully, we get to a point where Dask never calls this.
@gpucibot merge |
Thanks @madsbk for fixing this! |
Closes #861