Implement ProxifyHostFile.evict() #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #862 +/- ##
================================================
- Coverage 64.47% 64.42% -0.06%
================================================
Files 22 22
Lines 3099 3103 +4
================================================
+ Hits 1998 1999 +1
- Misses 1101 1104 +3
Continue to review full report at Codecov.
|
madsbk
added
3 - Ready for Review
pentschev
approved these changes
Feb 22, 2022
| @@ -583,25 +583,44 @@ def oom(nbytes: int) -> bool: | |||
| mr = rmm.mr.FailureCallbackResourceAdaptor(current_mr, oom) | |||
| rmm.mr.set_current_device_resource(mr) | |||
|
|
|||
| def evict(self) -> int: | |||
| """Manually evict 1% of host limit. | |||
There was a problem hiding this comment.
I understand this was already like this before and not quite sure how useful that would be, but should the 1% value be configurable somehow?
There was a problem hiding this comment.
I don't think that is necessary. Hopefully, we get to a point where Dask never calls this.
|
@gpucibot merge |
|
Thanks @madsbk for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #861