Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Dask's NVML tests #408

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

quasiben
Copy link
Member

@quasiben quasiben commented Oct 6, 2020

Run tests from dask/distributed#3810

@quasiben quasiben requested a review from a team as a code owner October 6, 2020 14:27
@quasiben quasiben changed the base branch from branch-0.16 to branch-0.17 October 6, 2020 14:28
@quasiben
Copy link
Member Author

quasiben commented Oct 6, 2020

Current test failures:

PackagesNotFoundError: The following packages are not available from current channels:

  - dask-cudf=0.17
  - ucx-py=0.17
  - cudf=0.17

Looks like a conda issue ?

@quasiben
Copy link
Member Author

quasiben commented Oct 6, 2020

rerun tests

@jakirkham
Copy link
Member

Yeah OPS is still working on creating those

@quasiben quasiben changed the base branch from branch-0.17 to branch-0.16 October 6, 2020 17:12
@quasiben
Copy link
Member Author

quasiben commented Oct 6, 2020

Temporarily targeting 0.16

@quasiben
Copy link
Member Author

quasiben commented Oct 6, 2020

rerun tests

@jakirkham
Copy link
Member

I think this still has history from branch-0.17, which is trying to still install 0.17 packages. Would recommend just rebasing on top of branch-0.16 and removing any commits from branch-0.17. That should hopefully fix the issue.

@quasiben quasiben changed the base branch from branch-0.16 to branch-0.17 October 6, 2020 22:29
@quasiben
Copy link
Member Author

quasiben commented Oct 6, 2020

I'll just wait until 0.17 things are fixed. Thanks @jakirkham

@quasiben
Copy link
Member Author

quasiben commented Oct 6, 2020

rerun tests

1 similar comment
@madsbk
Copy link
Member

madsbk commented Oct 7, 2020

rerun tests

@quasiben
Copy link
Member Author

quasiben commented Oct 7, 2020

Still seeing some conda issues. I think they should be resolved soon...

@jakirkham
Copy link
Member

Actually I think we need this in branch-0.16 as we consolidated the tests into distributed/diagnostics/tests/test_nvml.py. Though this is only a CI change, so should be safe. Would you be willing to retarget this to branch-0.16 and rebase on top of that branch, Ben?

@quasiben quasiben changed the base branch from branch-0.17 to branch-0.16 October 7, 2020 16:16
@jakirkham
Copy link
Member

May need to rebase to get rid of commit ( 25327eb ).

madsbk and others added 3 commits October 7, 2020 09:21
* explicit-comms: moved shuffle to its own file

* explicit-comms: implemented dataframe shuffle

* simplified the API

* Using Dask's _concat()
@quasiben quasiben force-pushed the fea-run-dask-nvml-tests branch from 3819aa1 to dcd7727 Compare October 7, 2020 16:21
@quasiben quasiben requested a review from a team as a code owner October 7, 2020 16:21
@quasiben
Copy link
Member Author

quasiben commented Oct 7, 2020

@raydouglass I removed the doc update 0.17 commit. We are targeting this fix for the upcoming release

@jakirkham
Copy link
Member

jakirkham commented Oct 7, 2020

For some reason the commit history shows some commit with explicit comms changes. However those changes are the same ones already in branch-0.16 as commit ( b6cfacc ). I think we can ignore those.

@jakirkham jakirkham mentioned this pull request Oct 7, 2020
@jakirkham jakirkham merged commit 93458a4 into rapidsai:branch-0.16 Oct 7, 2020
@jakirkham
Copy link
Member

For some reason the commit history shows some commit with explicit comms changes. However those changes are the same ones already in branch-0.16 as commit ( b6cfacc ). I think we can ignore those.

Note the resulting commit ( 93458a4 ) only contains the relevant CI change as expected.

@pentschev pentschev changed the title Run dask nvml tests Run Dask's NVML tests Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants