Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RMM_NO_INITIALIZE with RAPIDS_NO_INITIALIZE #371

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

jakirkham
Copy link
Member

No description provided.

@jakirkham jakirkham requested a review from a team as a code owner August 14, 2020 18:30
@jakirkham jakirkham mentioned this pull request Aug 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #371 into branch-0.15 will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.15     #371   +/-   ##
============================================
  Coverage        60.13%   60.13%           
============================================
  Files               17       17           
  Lines             1342     1342           
============================================
  Hits               807      807           
  Misses             535      535           
Impacted Files Coverage Δ
dask_cuda/benchmarks/utils.py 0.00% <0.00%> (ø)
dask_cuda/cuda_worker.py 72.50% <100.00%> (ø)
dask_cuda/initialize.py 93.33% <100.00%> (ø)
dask_cuda/local_cuda_cluster.py 83.52% <100.00%> (ø)
dask_cuda/utils.py 87.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4aa415...1eac907. Read the comment docs.

Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham !

@quasiben quasiben merged commit 1579b3b into rapidsai:branch-0.15 Aug 14, 2020
@jakirkham jakirkham deleted the use_rapids_no_init branch August 14, 2020 20:10
@kkraus14
Copy link
Contributor

Thanks all!

@kkraus14
Copy link
Contributor

cc @galipremsagar we can now change cuDF to look for this environment variable instead of the Dask environment variable.

@galipremsagar
Copy link
Contributor

Changed it as part of: rapidsai/cudf@6fb2db6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants