Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on Dask's ability to serialize collections #307

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Rely on Dask's ability to serialize collections #307

merged 1 commit into from
Jun 5, 2020

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jun 4, 2020 •
edited
Loading

Follow-up to PR ( #268 )
Requires ( #306 )
Uses ( dask/distributed#3689 )

As Dask is able to serialize collections of objects, simply serialize all of the parts together in one step.

@jakirkham
Rely on Dask's ability to serialize collections
037ccbc 
As Dask is able to serialize collections of objects, simply serialize
all of the parts together in one step.
@jakirkham jakirkham requested a review from a team as a code owner June 4, 2020 23:38
@jakirkham jakirkham mentioned this pull request Jun 4, 2020
Closed
@pentschev
Copy link
Member

#308 should fix errors.

@pentschev
Copy link
Member

rerun tests

@jakirkham
Copy link
Member Author

Thanks Peter! Looks like this is now passing 😄

pentschev
pentschev approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham !

@pentschev pentschev merged commit 840f000 into rapidsai:branch-0.15 Jun 5, 2020
@jakirkham jakirkham deleted the simp_serialization_spill_redux branch June 5, 2020 17:53
@jakirkham
Copy link
Member Author

Thanks Peter! 😄

@jakirkham jakirkham mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @pentschev