Conda release setup #66
Conversation
AjayThorve
commented
Nov 15, 2019
AjayThorve
commented
- Added setup files and conda recipes
| cd ${REPODIR}/../cuDataShader | ||
| python setup.py install --single-version-externally-managed --record=record.txt |
There was a problem hiding this comment.
I would cd back to $REPODIR after this installation. I'm also unsure how this will act in a conda build environment, but we can leave it as is and see.
build.sh
Outdated
| # script, and that this script resides in the repo dir! | ||
| REPODIR=$(cd $(dirname $0); pwd) | ||
|
|
||
| VALIDARGS="clean cuXfilter -v -g -n --allgpuarch -h" |
There was a problem hiding this comment.
All lowercase args
build.sh
Outdated
| --allgpuarch - build for all supported GPU architectures | ||
| -h - print this text | ||
| " | ||
| CUXFILTER_BUILD_DIR=${REPODIR}/python/cuXfilter/build |
There was a problem hiding this comment.
All lower case directories as well. Should change the python folder name to all lower in the repo as well.
ci/cpu/build.sh
Outdated
| ################################################################################ | ||
|
|
||
| logger "Build conda pkg for cuxfilter..." | ||
| source ci/cpu/cuxfilter/build_cuXfilter.sh |
There was a problem hiding this comment.
Lowercase script names.
ci/cpu/prebuild.sh
Outdated
| @@ -0,0 +1,15 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| #Upload cudf once per PYTHON | |||
There was a problem hiding this comment.
cudf --> cuxfilter
ci/cpu/prebuild.sh
Outdated
| #Upload libcudf once per CUDA | ||
| if [[ "$PYTHON" == "3.6" ]]; then | ||
| export UPLOAD_LIBCUDF=1 | ||
| else | ||
| export UPLOAD_LIBCUDF=0 | ||
| fi |
There was a problem hiding this comment.
This block is unneeded as you are python only.
ci/gpu/build.sh
Outdated
|
|
||
| cd $WORKSPACE/python/cuXfilter/tests | ||
| logger "Python py.test for cuXfilter..." | ||
| py.test --cache-clear --junitxml=${WORKSPACE}/junit-cuXfilter.xml -v --cov-config=.coveragerc --cov=cuXfilter --cov-report=xml:${WORKSPACE}/python/cuXfilter/cuXfilter-coverage.xml --cov-report term |
There was a problem hiding this comment.
All of the -cov arguments should be removed, they require CodeCov integration to do anything. Everything up to the -v stays, the rest should be deleted.
conda/recipes/cuXfilter/build.sh
Outdated
| # Copyright (c) 2018-2019, NVIDIA CORPORATION. | ||
|
|
||
| # This assumes the script is executed from the root of the repo directory | ||
| ./build.sh cudf |
There was a problem hiding this comment.
Should build cuxfilter and cudatashader here. Also folder name to all lowercase.
conda/recipes/cuXfilter/meta.yaml
Outdated
| - setuptools | ||
| run: | ||
| - python | ||
| - cudf=0.10 |
There was a problem hiding this comment.
| - cudf=0.10 | |
| - cudf {{ minor_version }} |
- renaming package/folder names to lowercase versions - typos - pytest command update to remove codecov as it's not integrated yet
|
Hey @dillon-cullinan, I have updated the files as per the requested changes. CuDatashader build path is still not all lowercase though, as the repo name itself is not all lower, and I believe I don't have the privileges to update that. Apart from that, I have updated everything else. |
| - nbsphinx | ||
| - numpydoc | ||
| - ipython | ||
| - altair |
Contributes to rapidsai/build-planning#31 Removes `.gitattributes` files. These were added in #66 for use with `versioneer`. Per the `git` docs ([link](https://git-scm.com/docs/gitattributes#_export_subst)), setting the attribute `export-subst` on a file via a `.gitattributes` tell `git` to replace placeholders in the file with some `git` information. This is no longer done in `_version.py` files in this project, and this project no longer uses `versioneer` (#497). `rapids-build-backend` handles storing git commit information in the published packages. ## Notes for Reviewers For more details, see rapidsai/build-planning#31 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) - Ajay Thorve (https://github.com/AjayThorve) URL: #603
