-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test with CUDA 12.5.1 #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be updated to 12.5:
cuxfilter/docs/source/user_guide/installation.rst
Lines 10 to 12 in 14237a1
# for CUDA 12.0 | |
conda install -c rapidsai -c conda-forge -c nvidia \ | |
cuxfilter=24.08 python=3.10 cuda-version=12.0 |
(context: rapidsai/dask-cuda#1357 (review))
This one is wrong (and looks like it has been since before this PR):
cuxfilter/docs/source/user_guide/installation.rst
Lines 35 to 42 in 14237a1
cuxfilter docker example installation for cuda 12.0, ubuntu 20.04: | |
.. code-block:: bash | |
# ex. for CUDA 11.8 | |
docker pull rapidsai/rapidsai:cuda12.0-runtime-ubuntu20.04 | |
docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786 \ | |
rapidsai/rapidsai:cuda11.8-runtime-ubuntu20.04 |
It's has a comment that says "for CUDA 11.8", but then pulls a CUDA 12.0 image, and then the docker run
after that docker pull
is for an 11.8 image.
The rapidsai/rapidsai
image isn't updated any more. Context: rapidsai/deployment#382
Since that doc is encouraging looking at a notebook at localhost:8888
, it should probably be using this image in both commands
rapidsai/notebooks:24.06-cuda12.0-py3.10
(ref: https://hub.docker.com/r/rapidsai/notebooks/tags)
I just posted a separate question (does not need to block this PR) about updating those images at rapidsai/build-planning#73.
/merge |
Thanks all! 🙏 |
This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.
Contributes to rapidsai/build-planning#73