fix matrix_filter to include cuda_11.x #597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjayThorve
added
non-breaking
AjayThorve
force-pushed
the
fix/cu-11-wheels-issue
branch
from
5d0de14
to
9d8268e
Compare
AjayThorve
force-pushed
the
fix/cu-11-wheels-issue
branch
from
9d8268e
to
dbf669b
Compare
|
/ok to test |
bdice
requested changes
May 28, 2024
Comment on lines
+76
to
+77
| # This selects "ARCH=amd64 + the latest supported Python + One each of (CUDA 11.x, CUDA 12.x)". | ||
| matrix_filter: '[.[] | select(.ARCH == "amd64")] | group_by(.CUDA_VER | split(".")[0]) | map(max_by([.PY_VER, .CUDA_VER]))' |
There was a problem hiding this comment.
Do we not support testing on ARM? Currently our matrix only includes wheel tests for (CUDA 12, amd64) and (CUDA 11, arm64). This effectively means that we're not testing wheels on CUDA 11 at all, if we don't test on ARM.
This suggestion might fix it (but it's untested):
Suggested change
| # This selects "ARCH=amd64 + the latest supported Python + One each of (CUDA 11.x, CUDA 12.x)". | |
| matrix_filter: '[.[] | select(.ARCH == "amd64")] | group_by(.CUDA_VER | split(".")[0]) | map(max_by([.PY_VER, .CUDA_VER]))' | |
| # This selects "ARCH=amd64 + the latest supported Python + One each of (CUDA 11.x, CUDA 12.x)". | |
| matrix_filter: 'group_by(.CUDA_VER | split(".")[0]) | map(max_by([.PY_VER, .CUDA_VER]))' |
|
This can probably by closed now that #590 is merged. cc: @AjayThorve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue caused by #575, which resulted in cu-11 wheels not being generated for cuxfilter.