Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to external tests #547

Merged
merged 3 commits into from
Oct 17, 2023
Merged

updates to external tests #547

merged 3 commits into from
Oct 17, 2023

Conversation

AjayThorve
Copy link
Member

This PR resolves the external tests still failing: https://github.com/rapidsai/cuxfilter/actions/runs/6485671242/job/17612261430.

Basically separately installing direct dependencies and then installing indirect dependencies from dependencies.yaml was downgrading rapids versions to 23.08 separately. This PR updates the dependencies to be in a single place (external_dependencies.yaml), while also adding it to ci/release/update-version.sh

There were a couple of dask.array tests in datashader which were failing when using pytest with --numprocesses flag, which is resolved here by separately running that test without the flag.

cc @exactlyallan

@AjayThorve AjayThorve requested a review from a team as a code owner October 11, 2023 23:33
@github-actions github-actions bot added the ci label Oct 11, 2023
@AjayThorve AjayThorve added non-breaking Non-breaking change ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working and removed ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround labels Oct 11, 2023
@rapidsai rapidsai deleted a comment from copy-pr-bot bot Oct 11, 2023
raydouglass
raydouglass approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the external_dependencies.yaml file already exists.

But, a future enhancement should be to move the external dependencies env file to be a file key in dependencies.yaml instead.

@AjayThorve
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 94456e0 into rapidsai:branch-23.12 Oct 17, 2023
29 checks passed
@AjayThorve
Copy link
Member Author

Approving since the external_dependencies.yaml file already exists.

But, a future enhancement should be to move the external dependencies env file to be a file key in dependencies.yaml instead.

I'll do a follow up PR with this, thanks!

@AjayThorve AjayThorve deleted the external-testing-workflow branch October 17, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@ajschmidt8 ajschmidt8 Awaiting requested review from ajschmidt8

Assignees
No one assigned
Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AjayThorve @raydouglass