Forward-merge branch-23.08 to branch-23.10 #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue raised in #511, which prevented the cuxfilter installation. This was caused by an indirect version conflict with pyproj (<3.4). This PR removes the `<3.4` pin, and also removes it as a direct run-dependency, since we only use it in notebooks. cc @exactlyallan resolves #511 Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Allan (https://github.com/exactlyallan) URL: #514
|
FAILURE - Unable to forward-merge due to conflicts, manual merge is necessary. Do not use the |
This PR adds updated Layouts, themes, a more intuitve API for show, and app commands, and support for the latest versions of panel, holoviews and bokeh. This PR will be followed up with another PR with updated documentation, example notebooks with updated API, and updated screenshots. Major API changes in this PR: - cuxfilter.dashboard.show(`height`=type(int), `sidebar_width`=type(int),) #width is responsive to user screen - cuxfilter.dashboard.app(`height`=type(int), width=type(int), `sidebar_width`=type(int),) in-notebook-cell rendering - Added more themes -> default, dark, rapids, rapids_dark, and `None` for custom palettes - Updated layout to be fully responsive, and consistent, whether it be within a notebook cell, or a separate web-app - Each chart can be rendered individually, using `chart.view(width, height)`. Executing `chart`(without explicitly calling `view()`) directly in a notebook cell, will automatically render the chart. - Web-app layout modified to include `fast.css` based widgets and js-actions (each chart can be expanded to full-screen for deeper exploration). cc @exactlyallan Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - Allan (https://github.com/exactlyallan) - Ray Douglass (https://github.com/raydouglass) URL: #492
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This PR refactors the bokeh charts implementation, and uses holoviews to generate the charts, while also using box-selects instead of range_sliders. This was done for 2 reasons, stability of holoviews api, which also is much more efficient, and to use streams + custom callbacks to link all charts with bar_charts. Some of the other notable changes: - Using holoviews to generate bokeh plots, allows us to `str` columns directly for bar charts - Persistent non-selection view for bar_charts - Got rid of redundant bokeh line chart, and now a single implementation exists under datashader/line, callable `cuxfilter.charts.line` - removed preview as pyppeteer was unstable - Refactor to remove redundant functions and classes Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - Allan (https://github.com/exactlyallan) - Ray Douglass (https://github.com/raydouglass) URL: #494
Follow up to #494, updates API docs and screenshots. cc @exactlyallan Authors: - Ajay Thorve (https://github.com/AjayThorve) Approvers: - Allan (https://github.com/exactlyallan)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## branch-23.10 #515 +/- ##
================================================
- Coverage 26.16% 26.01% -0.16%
================================================
Files 76 75 -1
Lines 4013 3756 -257
================================================
- Hits 1050 977 -73
+ Misses 2963 2779 -184
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-23.08that creates a PR to keepbranch-23.10up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.