Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheel builds to cuxfilter #497
Add wheel builds to cuxfilter #497
Changes from 25 commits
93e1471
952d660
2a13105
9736d17
595082f
10dcf41
964ebbd
1198848
b315075
49d3c88
9690c3f
6e92fa8
167ea9b
ebe0d1e
3c794bf
f975324
8194361
91f258e
582b416
e6fa115
efd2f4f
07ccd5c
238581a
7561383
f8e992e
343e4b7
580f1c0
9f1d287
000969c
e64915f
d3ee729
fb40b09
d124ee1
f20cb8c
ab01fd3
aab4898
0753fc3
01b9c4b
4ac9db1
ca1919c
991719c
0dd4755
3a674f3
67a2697
b517de1
940230e
7543e17
b41d1d4
630185f
f9cd11f
3e45265
ccbd94d
8c3556c
ad01bad
d5c393e
26e4712
6574a6c
a155801
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to borrow some logic from here for dask-cuda: https://github.com/rapidsai/cudf/blob/1899fb1990eae693bd74f92fa4a3f6a217889210/.github/workflows/pr.yaml#L132-L133
dask-cuda has to install from source, since the
23.8.*a*
packages on PyPI are pre-release / alphas. We can't really usepip install ... --pre
because it uses pre-release versions of all packages.Also note that you'll need to change
update-version.sh
to accomodate this. https://github.com/rapidsai/cudf/blob/1899fb1990eae693bd74f92fa4a3f6a217889210/ci/release/update-version.sh#L112I'm not sure if you need just dask-cuda or also dask/distributed so I have suggestions for both.
All of dask/distributed/dask-cuda:
Only dask-cuda:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay got it. It would just be dask-cuda at this point. Thanks again!
@bdice I am assuming this is a temporary fix, until dask-cuda has a PyPI stable release (23.8.*?), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @bdice, we don't need
dask_cuda
as a direct dependency, since it's only used in the dask_cudf based notebooks. So I removed the direct dependency, and added it tonotebooks
dependency onlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that the dependency could be moved.
To answer your question about whether this would be a temporary fix, it isn't temporary. The dask-cuda wheels used in CI are always pre-release alphas. We are always testing RAPIDS packages on
branch-XX.YY
against pre-releases of dask-cudaXX.YY
to ensure that when the releases are made, everything works together as intended.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, good to know. Thanks again for the thorough review. Let me know if this looks good to merge.
This file was deleted.
This file was deleted.
This file was deleted.