Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Add wheel builds to cuxfilter #491

Closed
4 tasks done
AjayThorve opened this issue Jun 8, 2023 · 1 comment · Fixed by #497
Closed
4 tasks done

[IMPROVEMENT] Add wheel builds to cuxfilter #491

AjayThorve opened this issue Jun 8, 2023 · 1 comment · Fixed by #497
Assignees
Labels
feature request New feature or request

Comments

@AjayThorve
Copy link
Member

AjayThorve commented Jun 8, 2023

Follow this guide to add wheels builds to cuxfilter.

  • Transition CI to GHA from Jenkins: The wheel builds use Github Actions.
  • Remove usage of versioneer: Various aspects of versioneer's operation and generated versions are incompatible with other parts of the Python ecosystem.
  • Migrate as much logic as possible from setup.py to pyproject.toml
  • Add wheels GHA workflows

cc @exactlyallan @bdice

edit: updated checklist as per suggestion

@AjayThorve AjayThorve added the feature request New feature or request label Jun 8, 2023
@AjayThorve AjayThorve self-assigned this Jun 8, 2023
@bdice
Copy link
Contributor

bdice commented Jun 8, 2023

A couple notes:

  1. You only need to use scikit-build if you have C++ built components. You can think of scikit-build as a bridge between Python build tools and CMake (for CUDA/C++ components). So you can skip that here.
  2. I shared these links in Slack but figured they could be useful here too:

Your best model to follow might be pure Python packages like dask-cudf because those are migrated but don't use scikit-build.

Also maybe there is a good opportunity for some cleanup of the Python code as a whole, I saw some bits while reviewing the build system like Makefile and record.txt that seem safe to remove.

@rapids-bot rapids-bot bot closed this as completed in #497 Jul 12, 2023
rapids-bot bot pushed a commit that referenced this issue Jul 12, 2023
This PR aims to  add wheels builds to cuxfilter

- [x] remove versioneer support
- [x] move build logic to pyproject.toml
- [x] add GHA to build, test and publish wheels
- [x] Update dependencies.yaml

Resolves #491
cc @bdice @exactlyallan

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)
  - Allan (https://github.com/exactlyallan)

URL: #497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants