CAGRA Python API #35
Merged
CAGRA Python API #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Ben Frederickson (https://github.com/benfred) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#31
Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai#32
cjnolet
added
improvement
Includes Cython and CMake fixes from testing.
dantegd
added
feature request
Somehow this change does not appear commented in my local clone
cjnolet
approved these changes
Mar 4, 2024
|
/merge |
cjnolet
approved these changes
Mar 4, 2024
AyodeAwe
approved these changes
Mar 4, 2024
This was referenced Mar 6, 2024
Closed
difyrrwrzd
added a commit
to difyrrwrzd/cuvs
that referenced
this pull request
Aug 10, 2024
PR does the following: - [x] Initial check in of new CAGRA Python API - [x] Initial check in of Cython using dlpack to call pylibcuvs - [x] Initial check in of pytests of CAGRA and docstrings - [x] Build updates for new files and algos - [x] Enable Python conda package and pytests run in CI - [x] Final cleanups Todos: - [x] Discussion regarding renaming `handle` to `resources` in Python API - [x] Testing exceptions handling while using C API or design strategy to enable that - [x] Finish todos that are not going to be solved in follow ups. Follow up PRs: - Moving cydlpack to RAFT. - Enable serialization - Enable update of dataset - Python API for other algorithms Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai/cuvs#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR does the following:
Todos:
handletoresourcesin Python APIFollow up PRs: