Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link to build docs and corrected ivf_flat_example #255

Merged

Conversation

mmccarty
Copy link
Contributor

Fixed link to build docs and corrected ivf_flat_example notebook for handles to resources kwarg change.

Copy link

copy-pr-bot bot commented Jul 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mmccarty mmccarty marked this pull request as ready for review July 26, 2024 21:07
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 29, 2024
README.md Outdated Show resolved Hide resolved
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cjnolet
Copy link
Member

cjnolet commented Jul 29, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jul 29, 2024

/merge

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Jul 29, 2024

/merge

@cjnolet
Copy link
Member

cjnolet commented Jul 30, 2024

/ok to test

@rapids-bot rapids-bot bot merged commit 6b3c06f into rapidsai:branch-24.10 Jul 30, 2024
54 checks passed
@mmccarty mmccarty deleted the readme-notebook-quick-fixes branch July 31, 2024 13:24
divyegala pushed a commit to divyegala/cuvs that referenced this pull request Aug 7, 2024
Fixed link to build docs and corrected ivf_flat_example notebook for handles to resources kwarg change.

Authors:
  - Mike McCarty (https://github.com/mmccarty)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

2 participants